cloud-fan commented on code in PR #50157:
URL: https://github.com/apache/spark/pull/50157#discussion_r1981583909
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala:
##########
@@ -140,11 +140,17 @@ abstract class SparkPlan extends QueryPlan[SparkPlan]
with Logging with Serializ
*/
def metrics: Map[String, SQLMetric] = Map.empty
+ /**
+ * @return All instance metrics of this SparkPlan.
+ */
+ def instanceMetrics: Map[String, SQLMetric] = Map.empty
Review Comment:
why do we add this method to the base class? It looks specific to the
`StateStoreWriter` operartor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
