MaxGekk commented on code in PR #50194:
URL: https://github.com/apache/spark/pull/50194#discussion_r1986236836
##########
dev/create-release/release-build.sh:
##########
@@ -137,6 +137,12 @@ if [[ "$1" == "finalize" ]]; then
--repository-url https://upload.pypi.org/legacy/ \
"pyspark_connect-$PYSPARK_VERSION.tar.gz" \
"pyspark_connect-$PYSPARK_VERSION.tar.gz.asc"
+ svn update "pyspark-client-$RELEASE_VERSION.tar.gz"
+ svn update "pyspark-client-$RELEASE_VERSION.tar.gz.asc"
+ TWINE_USERNAME=spark-upload TWINE_PASSWORD="$PYPI_PASSWORD" twine upload \
+ --repository-url https://upload.pypi.org/legacy/ \
+ "pyspark-client-$RELEASE_VERSION.tar.gz" \
+ "pyspark-client-$RELEASE_VERSION.tar.gz.asc"
Review Comment:
Please, revert unrelated changes.
##########
sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala:
##########
@@ -1197,6 +1197,35 @@ class UDFSuite extends QueryTest with SharedSparkSession
{
Row(Row(null)))
}
+ test("SPARK-51402: Test TimeType in UDF") {
+ // Mocks
+ val mockTimeStr = "00:00:00.000000"
+ val input = Seq(java.time.LocalTime.parse(mockTimeStr)).toDF("currentTime")
+ // Regular case
+ val plusHour = udf((l: java.time.LocalTime) => l.plusHours(1))
+ val result =
input.select(plusHour($"currentTime").cast(TimeType()).as("newTime"))
Review Comment:
I guess the case is not needed since the type is `TimeType()` already.
##########
sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala:
##########
@@ -862,7 +862,7 @@ class UDFSuite extends QueryTest with SharedSparkSession {
.select(myUdf1(Column("col"))),
Row(ArrayBuffer(100)))
- val myUdf2 = udf((a: immutable.ArraySeq[Int]) =>
+ val myUdf2 = udf((a: immutable.ArraySeq[Int]) =>
Review Comment:
ok, let's leave it but, please, avoid unrelated changes in the future:
- there are many places in code base where you could fix indentations. It is
better to open a separate PR, and focus only on this.
- the changes can cause merge conflicts in down stream branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
