beliefer commented on code in PR #50226: URL: https://github.com/apache/spark/pull/50226#discussion_r1988249742
########## sql/core/src/test/resources/sql-tests/results/misc-functions.sql.out: ########## @@ -58,7 +58,7 @@ array<int> map<int,int> struct<a:int,b:string> -- !query SELECT assert_true(true), assert_true(boolean(1)) -- !query schema -struct<assert_true(true, 'true' is not true!):void,assert_true(1, 'cast(1 as boolean)' is not true!):void> +struct<assert_true(true, 'true' is not true!):void,assert_true(1, '1' is not true!):void> Review Comment: I have a question 'cast(1 as boolean)' looks has more detail than '1'. Do we need to retain it？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
