micheal-o commented on code in PR #50123:
URL: https://github.com/apache/spark/pull/50123#discussion_r1990599552
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -38,9 +38,20 @@ import org.apache.spark.sql.types.StructType
import org.apache.spark.unsafe.Platform
import org.apache.spark.util.{NonFateSharingCache, Utils}
+/**
+ * Trait representing events reported from a RocksDB instance.
+ *
+ * The internal RocksDB instance can use a provider with a
`RocksDBEventListener` reference to
+ * report specific events like snapshot uploads. This should only be used to
report back to the
+ * coordinator for metrics and monitoring purposes.
+ */
+trait RocksDBEventListener {
+ def reportSnapshotUploaded(version: Long): Unit
+}
+
private[sql] class RocksDBStateStoreProvider
extends StateStoreProvider with Logging with Closeable
- with SupportsFineGrainedReplay {
+ with SupportsFineGrainedReplay with RocksDBEventListener {
Review Comment:
I would rather implement a separate class/object instead of adding this to
the provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
