Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5792#discussion_r31746451
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala ---
@@ -164,6 +165,18 @@ private[v1] class ApiRootResource extends
UIRootFromServletContext {
}
}
+ @Path("applications/{appId}/logs")
+ def getEventLogs(
+ @PathParam("appId") appId: String): EventLogDownloadResource = {
+ new EventLogDownloadResource(uiRoot, appId, None)
+ }
+
+ @Path("applications/{appId}/{attemptId}/logs")
+ def getEventLogs(
+ @PathParam("appId") appId: String,
+ @PathParam("attemptId") attemptId: String): EventLogDownloadResource =
{
--- End diff --
we can add a style checker for this in the future. this are also lots of
violations in Spark itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
