zhengruifeng commented on code in PR #50665:
URL: https://github.com/apache/spark/pull/50665#discussion_r2063365441
##########
mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala:
##########
@@ -169,6 +173,19 @@ abstract class MLWriter extends BaseReadWrite with Logging
{
saveImpl(path)
}
+ /**
+ * Saves the ML instances to the local file system path.
+ */
+ @throws[IOException]("If the input path already exists but overwrite is not
enabled.")
+ private[spark] def saveToLocal(path: String): Unit = {
Review Comment:
Instead of introduce a new `saveToLocal` method, what about adding new class
`MLLocalWriter extends MLWriter`?
Then based on the writer class, we can know whether an algorithm support
local read/write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
