MaxGekk commented on code in PR #50918:
URL: https://github.com/apache/spark/pull/50918#discussion_r2093742305
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -3873,6 +3873,12 @@
},
"sqlState" : "42000"
},
+ "JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR" : {
+ "message" : [
+ "JDBC external engine syntax error in <source>."
Review Comment:
As I can see the source is limited set of strings:
- "output schema resolution"
- "query execution"
How about to make 2 sub-conditions of "JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR"
instead of the parameter? In this way, we could:
1. avoid error text in source code. So, tech editors could modify the
`error-conditions.json` w/o recompiling spark
2. in the future we might have errors in different languages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
