viirya commented on code in PR #51010:
URL: https://github.com/apache/spark/pull/51010#discussion_r2106254609
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -3389,16 +3389,10 @@ object SparkContext extends Logging {
}
/**
- * This is a helper function to complete the missing S3A magic committer
configurations
- * based on a single conf:
`spark.hadoop.fs.s3a.bucket.<bucket>.committer.magic.enabled`
+ * Enable Magic Committer by default for all S3 buckets if hadoop-cloud
module exists.
*/
- private def fillMissingMagicCommitterConfsIfNeeded(conf: SparkConf): Unit = {
- val magicCommitterConfs = conf
- .getAllWithPrefix("spark.hadoop.fs.s3a.bucket.")
- .filter(_._1.endsWith(".committer.magic.enabled"))
- .filter(_._2.equalsIgnoreCase("true"))
- if (magicCommitterConfs.nonEmpty &&
-
Utils.classIsLoadable("org.apache.spark.internal.io.cloud.BindingParquetOutputCommitter")
&&
Review Comment:
Not related to this PR, but I wonder this looks like for parquet only? If we
are writing into other than parquet, do we still require this for magic
committer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
