cloud-fan commented on code in PR #51092:
URL: https://github.com/apache/spark/pull/51092#discussion_r2130246800
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala:
##########
@@ -43,6 +43,7 @@ class DataSourceV2DataFrameSuite
before {
spark.conf.set("spark.sql.catalog.testcat",
classOf[InMemoryTableCatalog].getName)
spark.conf.set("spark.sql.catalog.testcat2",
classOf[InMemoryTableCatalog].getName)
+ spark.conf.set(SQLConf.ANSI_ENABLED.key, "true")
Review Comment:
This works but we shouldn't set this conf repeatedly for each test case. I
still prefer to override `def sparkConf` to set the conf once for the entire
suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
