Pajaraja commented on code in PR #51097:
URL: https://github.com/apache/spark/pull/51097#discussion_r2136009603


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -947,30 +947,14 @@ trait CheckAnalysis extends LookupCatalog with 
QueryErrorsBase with PlanToString
     if (expr.plan.isStreaming) {
       plan.failAnalysis("INVALID_SUBQUERY_EXPRESSION.STREAMING_QUERY", 
Map.empty)
     }
-    assertNoRecursiveCTE(expr.plan)

Review Comment:
   It shouldn't be; since now (when we allowed subquery references in recursive 
CTEs) we replace them with UnionLoopRef, so this will never fail!
   
   As it currently stands, I think this is dead code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to