dongjoon-hyun commented on code in PR #51174:
URL: https://github.com/apache/spark/pull/51174#discussion_r2150445323


##########
scalastyle-config.xml:
##########
@@ -288,6 +288,12 @@ This file is divided into 3 sections:
     of Commons Lang 2 (package org.apache.commons.lang.*)</customMessage>
   </check>
 
+  <check customId="commonslang3javaversion" level="error" 
class="org.scalastyle.file.RegexChecker" enabled="true">
+    <parameters><parameter 
name="regex">org\.apache\.commons\.lang3\.JavaVersion</parameter></parameters>

Review Comment:
   We need more complex pattern due to the curly brace, `{`.
   
   ```
    $ git grep JavaVersion | grep import
   core/src/main/scala/org/apache/spark/util/Utils.scala:import 
org.apache.commons.lang3.{JavaVersion, SystemUtils}
   
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:import
 org.apache.commons.lang3.{JavaVersion, SystemUtils}
   
streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala:import
 org.apache.commons.lang3.{JavaVersion, SystemUtils}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to