dongjoon-hyun commented on PR #241: URL: https://github.com/apache/spark-kubernetes-operator/pull/241#issuecomment-2980866510
To @jiangzho , the AS-IS methodology is very simpler than you are trying to do. To be short, we only generate the current one and **insert** it to the existing yaml file additionally. The deletion is also simpler than this. We clean up the YAML file simply by removing the old entries. As we see in this PR, this PR's approach is error prone. 1. We already made a mistake at the first commit. 2. In addition, this PR requires us to maintain the corresponding generator code. 3. To remove old entry, we need to remove the source code and regenerate it. Although I tested this PR with a hope initially, it turned out this is not what we want in the community. Let's not support generating multiple versions. Sorry for objecting your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
