yhuang-db commented on code in PR #51236:
URL: https://github.com/apache/spark/pull/51236#discussion_r2165071840
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -2567,6 +2571,266 @@ class DataFrameAggregateSuite extends QueryTest
checkAnswer(df, Row(1.001d, 1, 1) :: Row(6.002d, 1, 1) :: Nil)
}
}
+
+ test("SPARK-52515: test of 1 parameter") {
+ val res = sql(
+ "SELECT approx_top_k(expr) FROM VALUES (0), (0), (1), (1), (2), (3),
(4), (4) AS tab(expr);"
+ )
+ checkAnswer(res, Row(Seq(Row(0, 2), Row(4, 2), Row(1, 2), Row(2, 1),
Row(3, 1))))
+ }
+
+ test("SPARK-52515: test of 2 parameter") {
+ val res = sql(
+ "SELECT approx_top_k(expr, 2) " +
+ "FROM VALUES 'a', 'b', 'c', 'c', 'c', 'c', 'd', 'd' AS tab(expr);")
+ checkAnswer(res, Row(Seq(Row("c", 4), Row("d", 2))))
+ }
+
+ test("SPARK-52515: test of 3 parameter") {
+ val res = sql(
+ "SELECT approx_top_k(expr, 10, 100) FROM VALUES (0), (1), (1), (2), (2),
(2) AS tab(expr);"
+ )
+ checkAnswer(res, Row(Seq(Row(2, 3), Row(1, 2), Row(0, 1))))
+ }
+
+ test("SPARK-52515: test of Integer type") {
+ val res = sql(
+ "SELECT approx_top_k(expr) FROM VALUES (0), (0), (1), (1), (2), (3),
(4), (4) AS tab(expr);"
+ )
+ checkAnswer(res, Row(Seq(Row(0, 2), Row(4, 2), Row(1, 2), Row(2, 1),
Row(3, 1))))
+ }
+
+ test("SPARK-52515: test of String type") {
Review Comment:
Cannot support binary type for now. It seems that ItemSketch from Apache
DataSketches cannot count for byte[]. Commented in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
