aokolnychyi commented on code in PR #51091:
URL: https://github.com/apache/spark/pull/51091#discussion_r2165427058
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/MergeRowsExec.scala:
##########
@@ -45,6 +47,14 @@ case class MergeRowsExec(
output: Seq[Attribute],
child: SparkPlan) extends UnaryExecNode {
+ override lazy val metrics: Map[String, SQLMetric] = Map(
+ "numTargetRowsCopied" -> SQLMetrics.createMetric(sparkContext,
+ "Number of target rows rewritten unmodified because they did not meet
any condition."),
Review Comment:
Also, what about "as they didn't match any action"? It is not clear what we
mean by condition here.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/MergeRowsExec.scala:
##########
@@ -45,6 +47,14 @@ case class MergeRowsExec(
output: Seq[Attribute],
child: SparkPlan) extends UnaryExecNode {
+ override lazy val metrics: Map[String, SQLMetric] = Map(
+ "numTargetRowsCopied" -> SQLMetrics.createMetric(sparkContext,
+ "Number of target rows rewritten unmodified because they did not meet
any condition."),
Review Comment:
Why not say "rows copied unmodified" given the name of the metric? I think
"copy" is the right word here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
