AnishMahto commented on code in PR #51344:
URL: https://github.com/apache/spark/pull/51344#discussion_r2178530981
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/GraphRegistrationContext.scala:
##########
@@ -49,35 +49,54 @@ class GraphRegistrationContext(
flows += flowDef.copy(sqlConf = defaultSqlConf ++ flowDef.sqlConf)
}
+ /**
Review Comment:
I just added the scaladoc for the sake of future readers, but the changes to
`toDataflowGraph` are relevant.
`toDataflowGraph` is where we ensure all identifiers are fully qualified,
and qualify if not. It's intentional that once we fully qualify (or verify that
the identifier is already fully qualified), we also update the associated query
origin with the fully qualified identifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]