PetarVasiljevic-DB commented on code in PR #50921:
URL: https://github.com/apache/spark/pull/50921#discussion_r2192723418
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCScanBuilder.scala:
##########
@@ -194,4 +304,13 @@ case class JDBCScanBuilder(
JDBCScan(JDBCRelation(schema, parts, jdbcOptions)(session), finalSchema,
pushedPredicate,
pushedAggregateList, pushedGroupBys, tableSample, pushedLimit,
sortOrders, pushedOffset)
}
+
+}
+
+object JoinPushdownAliasGenerator {
+ private val subQueryId = new java.util.concurrent.atomic.AtomicLong()
Review Comment:
I'm not sure how to do it on query level.
We can have a counter in the JDBCScanBuilder, but then if you have JOIN of 2
already pushed down joins, subquery aliases of left and right child would have
same values. It's probably possible to get around this issue but I think it
adds a lot of complexity.
We are already using Object for `SPARK_GEN_SUBQ_` in `JDBCOptions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
