ekrich commented on code in PR #50474:
URL: https://github.com/apache/spark/pull/50474#discussion_r2198167319
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala:
##########
@@ -128,17 +128,17 @@ object SparkKubernetesClientFactory extends Logging {
object ClientType extends Enumeration {
import scala.language.implicitConversions
- val Driver = Val(DRIVER_CLIENT_REQUEST_TIMEOUT,
DRIVER_CLIENT_CONNECTION_TIMEOUT)
- val Submission = Val(SUBMISSION_CLIENT_REQUEST_TIMEOUT,
SUBMISSION_CLIENT_CONNECTION_TIMEOUT)
+ val Driver = ClientTypeVal(DRIVER_CLIENT_REQUEST_TIMEOUT,
DRIVER_CLIENT_CONNECTION_TIMEOUT)
Review Comment:
These enumerations should probably be put in a `scala-2` source along with
adding a `scala-3` source with real enums that are compatible with Java. Since
they are inline it might mean some code duplication.
Example:
https://github.com/ekrich/sconfig/blob/main/sconfig/shared/src/main/scala-3/org/ekrich/config/ConfigValueType.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
