pasar6987 opened a new pull request, #51465:
URL: https://github.com/apache/spark/pull/51465
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fixes a bug in `ParseToDate` and `ParseToTimestamp` expressions
where they incorrectly applied timezone conversion when processing
`TimestampNTZ` inputs.
**Technical details:**
Both classes previously used `SQLConf.get.timestampType` (which defaults to
`TimestampType`) for `GetTimestamp` creation regardless of input type. The fix
introduces conditional logic:
```scala
val timestampType = if (left.dataType == TimestampNTZType) TimestampNTZType
else dataType
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
`TimestampNTZ` represents timestamps without timezone information and should
not undergo timezone conversion. However, `ParseToDate` and `ParseToTimestamp`
were incorrectly applying timezone conversion to `TimestampNTZ` inputs,
violating the semantics of the `TimestampNTZ` type.
**Example of the bug:**
```sql
SET spark.sql.session.timeZone = Asia/Seoul;
SELECT to_timestamp(timestamp_ntz'2000-09-01T20:00:00', '');
```
- **Before fix**: Returns `2000-09-02 05:00:00` (incorrectly applied +9 hour
timezone offset)
- **After fix**: Returns `2000-09-01 20:00:00` (correctly preserves original
time)
This bug affects any usage of `to_timestamp` or `to_date` functions with
`TimestampNTZ` inputs in environments with non-UTC session timezones.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
**Yes.** This is a bug fix that changes the behavior of `to_timestamp` and
`to_date` functions when processing `TimestampNTZ` inputs.
**Previous behavior (incorrect):**
```sql
spark.sql.session.timeZone = Asia/Seoul
to_timestamp(timestamp_ntz'2000-09-01T20:00:00', '') → 2000-09-02 05:00:00
to_date(timestamp_ntz'2000-09-01T20:00:00') → 2000-09-02
```
**New behavior (correct):**
```sql
spark.sql.session.timeZone = Asia/Seoul
to_timestamp(timestamp_ntz'2000-09-01T20:00:00', '') → 2000-09-01 20:00:00
to_date(timestamp_ntz'2000-09-01T20:00:00') → 2000-09-01
```
Users relying on the previous incorrect behavior may need to adjust their
queries, but the new behavior correctly implements `TimestampNTZ` semantics.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
1. **Unit test added**: `DateFunctionsSuite` now includes test case
`"SPARK-52457: to_timestamp and to_date with TimestampNTZ should not apply
timezone"` that:
- Sets session timezone to `Asia/Seoul`
- Tests `to_timestamp` and `to_date` with `TimestampNTZ` input
- Verifies that original time is preserved without timezone conversion
2. **Existing tests**: All existing `DateFunctionsSuite` tests pass.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
