urosstan-db commented on PR #51474:
URL: https://github.com/apache/spark/pull/51474#issuecomment-3069806723
> Can we avoid new case class by using Map[Sting, A] instead of GridTestCase?
No, I want to have GridTestCase since Map does not allow parameter naming
and usage of case class gives is cleaner for reviewers who don't know how
`gridTest` signature looks like:
```
gridTest("Test name prefix")(Map(
"partitioning enabled" -> true,
"partitioning disabled" -> false,
))
```
vs
```
gridTest("Test name prefix")(Seq(
GridTestCase(
nameSuffix = "partitioning enabled",
true
),
GridTestCase(
nameSuffix = "partitioning disabled",
false
),
))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
