peter-toth commented on code in PR #51464:
URL: https://github.com/apache/spark/pull/51464#discussion_r2205131962


##########
sql/connect/common/src/main/protobuf/spark/connect/types.proto:
##########
@@ -69,6 +69,8 @@ message DataType {
 
     // UnparsedDataType
     Unparsed unparsed = 24;
+
+    Time time = 28;

Review Comment:
   Unfortunately these are not in order. A few lines up:
   
   ```
     Variant variant = 25;
   ```
   and down:
   ```
     // Reserved for geometry and geography types
     reserved 26, 27;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to