MaxGekk commented on code in PR #51467: URL: https://github.com/apache/spark/pull/51467#discussion_r2212655302
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/LiteralTypeOps.scala: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.types + +import org.apache.spark.sql.catalyst.expressions.Literal +import org.apache.spark.sql.types.{DataType, TimeType} + +// Literal operations over Catalyst's types +trait LiteralTypeOps { + // Gets a literal with default value of the type + def getDefaultLiteral: Literal +} + +object LiteralTypeOps { + def supports(dt: DataType): Boolean = dt match { + case _: TimeType => true + case _ => false + } Review Comment: > This looks like duplicate code, compared to PhyTypeOps This check in `LiteralTypeOps` is not duplicate of the code in `PhyTypeOps` because the code in `LiteralTypeOps` checks a DataType supports the `LiteralTypeOps` interface, but the same code in `PhyTypeOps` checks another interface. I think when we support more DataTypes like `TimeType` we can replace this pattern matching by a set operation like: ```scala private val supportedDataTypes = Set(AnyTimeType, AnsiIntervalType) def supports(dt: DataType): Boolean = supportedDataTypes.contain(dt) ``` that we wanted to avoid in the first place (adding TimeTime to a bunch of matches). Yep, this is the goal. Ideally we should propagate `TypeOps` objects instead of `DataType`, but for now it requires tons of changes. Current approach is temporary workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
