cloud-fan commented on code in PR #51686:
URL: https://github.com/apache/spark/pull/51686#discussion_r2242071690
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala:
##########
@@ -226,10 +195,54 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
}
}
- def generateJoinOutputAlias(name: String): String =
- s"${name}_${java.util.UUID.randomUUID().toString.replace("-", "_")}"
+ private def generateColumnAliasesForDuplicatedName(
+ leftSideRequiredColumnNames: Array[String],
+ rightSideRequiredColumnNames: Array[String]
+ ): (Array[SupportsPushDownJoin.ColumnWithAlias],
+ Array[SupportsPushDownJoin.ColumnWithAlias]) = {
+ // Count occurrences of each column name across both sides to identify
duplicates.
+ val allRequiredColumnNames = leftSideRequiredColumnNames ++
rightSideRequiredColumnNames
+ val allNameCounts: Map[String, Int] =
+ allRequiredColumnNames.groupBy(identity).view.mapValues(_.size).toMap
Review Comment:
shall we consider case sensitivity? if the left side has `col` and right
side has `COL`, do we need to generate alias?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
