uros-db commented on code in PR #51715:
URL: https://github.com/apache/spark/pull/51715#discussion_r2242723915
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala:
##########
@@ -716,6 +716,43 @@ object DateTimeUtils extends SparkDateTimeUtils {
(endNanos - startNanos) / NANOS_PER_MICROS
}
+ // Helper method to get the number of nanoseconds per the given time unit,
used for calculating
+ // the difference between two time values (timediff function). Supported
units are: MICROSECOND,
+ // MILLISECOND, SECOND, MINUTE, HOUR.
+ private def getNanosPerTimeUnit(unit: UTF8String): Long = {
+ val unitStr = unit.toString
+ unitStr.toUpperCase(Locale.ROOT) match {
+ case "MICROSECOND" =>
+ NANOS_PER_MICROS
+ case "MILLISECOND" =>
+ NANOS_PER_MILLIS
+ case "SECOND" =>
+ NANOS_PER_SECOND
+ case "MINUTE" =>
+ NANOS_PER_SECOND * SECONDS_PER_MINUTE
+ case "HOUR" =>
+ NANOS_PER_SECOND * SECONDS_PER_MINUTE * MINUTES_PER_HOUR
+ case _ =>
+ throw QueryExecutionErrors.invalidTimeUnitError("timediff", unitStr)
+ }
+ }
+
+ /**
+ * Gets the difference between two time values in the specified unit.
+ *
+ * @param unit Specifies the interval units in which to express the
difference between
+ * the two time parameters. Supported units are: MICROSECOND,
MILLISECOND,
+ * SECOND, MINUTE, HOUR.
+ * @param startNanos A time value expressed as nanoseconds since the start
of the day,
+ * which the function subtracts from `endNanos`.
+ * @param endNanos A time value expressed as nanoseconds since the start of
the day,
+ * from which the function subtracts `startNanos`.
+ * @return The time span between two time values, in the units specified.
+ */
+ def timeDiff(unit: UTF8String, startNanos: Long, endNanos: Long): Long = {
+ (endNanos - startNanos) / getNanosPerTimeUnit(unit)
Review Comment:
Not for valid time input (nanos between 00:00:00 and 23:59:59.999999999).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
