Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6388#discussion_r31874786
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -47,6 +49,39 @@ class MultivariateOnlineSummarizer extends
MultivariateStatisticalSummary with S
private var currMax: Array[Double] = _
private var currMin: Array[Double] = _
+ private var configure: mutable.Map[String, Boolean] = mutable.Map("mean"
-> false, "max" -> false,
+ "min" -> false, "variance" -> false, "normL1" -> false, "normL2" ->
false)
+
+ def withMean(flag: Boolean): this.type = {
+ configure("mean") = flag
+ this
+ }
+
--- End diff --
okay. I see why you want to use `map`. it will be easier to compare with
the other map. since those are private, i think it's okay for now. please have
local copy as `val` in function as the following.
also, the variable name in function will be part of api. please have it
more descriptive like
```scala
def setWithMax(withMax: Boolean): this.type = {
configure("withMax") = withMax
this
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
