pan3793 opened a new pull request, #52110:
URL: https://github.com/apache/spark/pull/52110
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes introducing a JDBC Driver for Spark Connect Server.
Note: The JDBC standard defines hundreds of APIs, most JDBC drivers only
implement a subset of those. This PR is a PoC work that only implements a few
sets of JDBC API, but allows integrating with BeeLine to use as a SQL CLI.
This PoC PR only handles `NULL`, `BOOLEAN`, `BYTE`, `SHORT`, `INT`,
`BIGINT`, `FLOAT`, `DOUBLE`, `STRING` in `ResultSet`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This enables more pure SQL use cases for Spark Connect Server.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, a new feature.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
#### 1. Add some basic UTs.
#### 2. Manual test with BeeLine
Start a Connect Server first.
```
$ sbin/start-connect-server.sh
```
Package with Hive and STS (required by BeeLine)
```
$ build/sbt -Phive,hive-thriftserver package
```
Run BeeLine in interactive mode.
```
$ SPARK_PREPEND_CLASSES=true bin/beeline -u jdbc:sc://localhost:15002
NOTE: SPARK_PREPEND_CLASSES is set, placing locally compiled Spark classes
ahead of assembly.
WARNING: Using incubator modules: jdk.incubator.vector
Connecting to jdbc:sc://localhost:15002
Connected to: Apache Spark Connect Server (version 4.0.0)
Driver: Apache Spark Connect JDBC Driver (version 4.1.0-SNAPSHOT)
Transaction isolation: TRANSACTION_REPEATABLE_READ
Beeline version 2.3.10 by Apache Hive
0: jdbc:sc://localhost:15002> select 'Hello, Spark Connect', version();
Using Spark's default log4j profile:
org/apache/spark/log4j2-defaults.properties
25/08/25 12:04:09 WARN Utils: Your hostname, H27212-MAC-01.local, resolves
to a loopback address: 127.0.0.1; using 10.242.159.140 instead (on interface
en0)
25/08/25 12:04:09 WARN Utils: Set SPARK_LOCAL_IP if you need to bind to
another address
+-----------------------+-------------------------------------------------+
| Hello, Spark Connect | version() |
+-----------------------+-------------------------------------------------+
| Hello, Spark Connect | 4.0.0 fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4 |
+-----------------------+-------------------------------------------------+
1 row selected (1.759 seconds)
0: jdbc:sc://localhost:15002>
```
Run BeeLine to execute a SQL file
```
$ cat > /tmp/select.sql <<EOF
select 'Hello, Spark Connect';
select version();
EOF
$ SPARK_PREPEND_CLASSES=true bin/beeline -u jdbc:sc://localhost:15002 -f
/tmp/select.sql
NOTE: SPARK_PREPEND_CLASSES is set, placing locally compiled Spark classes
ahead of assembly.
WARNING: Using incubator modules: jdk.incubator.vector
Connecting to jdbc:sc://localhost:15002
Connected to: Apache Spark Connect Server (version 4.0.0)
Driver: Apache Spark Connect JDBC Driver (version 4.1.0-SNAPSHOT)
Transaction isolation: TRANSACTION_REPEATABLE_READ
0: jdbc:sc://localhost:15002> select 'Hello, Spark Connect';
Using Spark's default log4j profile:
org/apache/spark/log4j2-defaults.properties
25/08/25 12:04:52 WARN Utils: Your hostname, H27212-MAC-01.local, resolves
to a loopback address: 127.0.0.1; using 10.242.159.140 instead (on interface
en0)
25/08/25 12:04:52 WARN Utils: Set SPARK_LOCAL_IP if you need to bind to
another address
+-----------------------+
| Hello, Spark Connect |
+-----------------------+
| Hello, Spark Connect |
+-----------------------+
1 row selected (0.462 seconds)
0: jdbc:sc://localhost:15002> select version();
+-------------------------------------------------+
| version() |
+-------------------------------------------------+
| 4.0.0 fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4 |
+-------------------------------------------------+
1 row selected (0.046 seconds)
0: jdbc:sc://localhost:15002>
0: jdbc:sc://localhost:15002> Closing: 0: jdbc:sc://localhost:15002
$
```
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
