jcw024 commented on PR #52062: URL: https://github.com/apache/spark/pull/52062#issuecomment-3226871525
Thanks for making the updates. Just a couple last suggestions, can we also update the arguments to include `date` similar to how it's done in the other MakeTimestamp ExpressionBuilders? > * date - a date to represent, from 0001-01-01 to 9999-12-31 Also, I'm wondering if we should also apply similar changes to TryMakeTimestampLTZExpressionBuilder. I think it would make sense to also go in this PR since the change is so similar, but I'm not sure how it was done for the other TryMakeTimestamp ExpressionBuilders -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
