JiaqiWang18 commented on code in PR #52119:
URL: https://github.com/apache/spark/pull/52119#discussion_r2309275822
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/pipelines/PythonPipelineSuite.scala:
##########
@@ -434,6 +434,34 @@ class PythonPipelineSuite
.map(_.identifier) == Seq(graphIdentifier("a"),
graphIdentifier("something")))
}
+ test("MV/ST with partition columns works") {
+ val graph = buildGraph("""
+ |from pyspark.sql.functions import col
+ |
+ |@dp.materialized_view(partition_cols = ["id_mod"])
+ |def mv():
+ | return spark.range(5).withColumn("id_mod", col("id") % 2)
+ |
+ |@dp.table(partition_cols = ["id_mod"])
+ |def st():
+ | return spark.readStream.table("mv")
+ |""".stripMargin)
+
+ val updateContext = new PipelineUpdateContextImpl(graph, eventCallback = _
=> ())
+ updateContext.pipelineExecution.runPipeline()
+ updateContext.pipelineExecution.awaitCompletion()
Review Comment:
we actually don't extend `PipelineTest` in `PythonPipelineSuite`, adding it
is causing some conflict in the inheritance hierarchy. `PipelineTest` does have
a lot of helpful methods like `checkAnswer`, might worth to do a refactor
separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
