PetarVasiljevic-DB commented on code in PR #52198:
URL: https://github.com/apache/spark/pull/52198#discussion_r2318065845
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -391,10 +391,27 @@ abstract class JdbcDialect extends Serializable with
Logging {
protected def predicateToIntSQL(input: String): String =
"CASE WHEN " + input + " THEN 1 ELSE 0 END"
+ /**
+ * For third-party JDBC dialects, we are not sure if WHERE ([TRUE/FALSE])
can be
+ * executed. Therefore, by default, it will be replaced with WHERE ([1 = 1
/ 1 = 0]).
+ */
+ protected def translateBooleanLiteralsAsComparison: Boolean = true
Review Comment:
no, sorry, `WHERE TRUE` does not work in older versions of Oracle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
