yaooqinn commented on code in PR #52192:
URL: https://github.com/apache/spark/pull/52192#discussion_r2315351136


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala:
##########
@@ -327,7 +327,7 @@ trait FileSourceScanLike extends DataSourceScanExec {
     relation.fileFormat.vectorTypes(
       requiredSchema = requiredSchema,
       partitionSchema = relation.partitionSchema,
-      relation.sparkSession.sessionState.conf).map { vectorTypes =>
+      getSqlConf(relation.sparkSession)).map { vectorTypes =>

Review Comment:
   Thank you for the suggestion. @peter-toth 
   
   Because SparkPlan has also defined a field of SQLConf, and these 
`*FileSourceScan*` files visit conf very inconsistently, I decided to make 
in-place updates instead of extracting a common field to avoid potential 
regression.
   
   I can verify this part in a separate PR.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to