EnricoMi commented on code in PR #51199:
URL: https://github.com/apache/spark/pull/51199#discussion_r2319970750
##########
core/src/main/scala/org/apache/spark/storage/FallbackStorage.scala:
##########
@@ -95,15 +96,21 @@ private[storage] class FallbackStorage(conf: SparkConf)
extends Logging {
}
}
-private[storage] class NoopRpcEndpointRef(conf: SparkConf) extends
RpcEndpointRef(conf) {
+private[storage] class FallbackStorageRpcEndpointRef(conf: SparkConf,
hadoopConf: Configuration)
+ extends RpcEndpointRef(conf) {
// scalastyle:off executioncontextglobal
import scala.concurrent.ExecutionContext.Implicits.global
// scalastyle:on executioncontextglobal
override def address: RpcAddress = null
override def name: String = "fallback"
override def send(message: Any): Unit = {}
override def ask[T: ClassTag](message: Any, timeout: RpcTimeout): Future[T]
= {
- Future{true.asInstanceOf[T]}
+ message match {
+ case RemoveShuffle(shuffleId) =>
Review Comment:
When an unused shuffle is garbage collected on the driver:
https://github.com/apache/spark/blob/b01747341918b4ac4e13ec35c9e816fa9239754b/core/src/main/scala/org/apache/spark/ContextCleaner.scala#L188-L220
https://github.com/apache/spark/blob/b01747341918b4ac4e13ec35c9e816fa9239754b/core/src/main/scala/org/apache/spark/ContextCleaner.scala#L234-L251
https://github.com/apache/spark/blob/b01747341918b4ac4e13ec35c9e816fa9239754b/core/src/main/java/org/apache/spark/shuffle/sort/io/LocalDiskShuffleDriverComponents.java#L43-L48
https://github.com/apache/spark/blob/b01747341918b4ac4e13ec35c9e816fa9239754b/core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala#L202-L213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
