viirya commented on code in PR #50765: URL: https://github.com/apache/spark/pull/50765#discussion_r2339276748
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala: ########## @@ -130,7 +136,7 @@ case class ParquetPartitionReaderFactory( new PartitionReader[InternalRow] { private var hasNext = true private lazy val row: InternalRow = { - val footer = getFooter(file) + val (_, _, footer) = openFileAndReadFooter(file) Review Comment: If I read it correctly, previously for non-vectorized case, `getFooter` skips row groups (`SKIP_ROW_GROUPS`). But now `openFileAndReadFooter` always reading footer with row groups? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org