cloud-fan commented on code in PR #52299: URL: https://github.com/apache/spark/pull/52299#discussion_r2341038091
########## sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSessionCatalogSuite.scala: ########## @@ -133,7 +133,9 @@ class InMemoryTableSessionCatalog extends TestV2SessionCatalogBase[InMemoryTable } val newTable = new InMemoryTable(table.name, schema, table.partitioning, properties) - .withData(table.data) + .withData(table.data, Review Comment: shall we add a overload of `withData` that takes `Array[Column]`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org