dongjoon-hyun commented on code in PR #322:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/322#discussion_r2356937551
##########
config/pmd/ruleset.xml:
##########
@@ -41,6 +41,7 @@
<exclude name="TooManyStaticImports" />
<exclude name="UseExplicitTypes" />
<exclude name="UseUnderscoresInNumericLiterals" />
+ <exclude name="TypeParameterNamingConventions" />
Review Comment:
Although this is a new rule, it doesn't fit our usage. For example, we use
*word* for parameter names but this rule enforces to use a single letter.
https://github.com/apache/spark-kubernetes-operator/blob/c07e61eaf17b785777b49a078efe085f18164d3a/spark-operator-api/src/main/java/org/apache/spark/k8s/operator/BaseResource.java#L34-L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
