LuciferYang commented on code in PR #52261:
URL: https://github.com/apache/spark/pull/52261#discussion_r2372952827
##########
core/src/test/scala/org/apache/spark/deploy/SparkPipelinesSuite.scala:
##########
@@ -113,6 +113,72 @@ class SparkPipelinesSuite extends SparkSubmitTestUtils
with BeforeAndAfterEach {
}
}
+ test("spark.api.mode arg") {
+ var args = Array("--conf", "spark.api.mode=classic")
+ intercept[SparkUserAppException] {
+ SparkPipelines.constructSparkSubmitArgs(args, sparkHome = "abc")
+ }
+ args = Array("-c", "spark.api.mode=classic")
+ intercept[SparkUserAppException] {
+ SparkPipelines.constructSparkSubmitArgs(args, sparkHome = "abc")
+ }
+ args = Array("--conf", "spark.api.mode=CONNECT")
+ assert(
+ SparkPipelines.constructSparkSubmitArgs(args, sparkHome = "abc") ==
+ Seq(
+ "--conf",
+ "spark.api.mode=connect",
+ "--remote",
+ "local",
+ "abc/python/pyspark/pipelines/cli.py"
+ )
+ )
+ args = Array("--conf", "spark.api.mode=CoNNect")
+ assert(
+ SparkPipelines.constructSparkSubmitArgs(args, sparkHome = "abc") ==
Review Comment:
The method signature has been modified, and a rebase is required; otherwise,
compilation will fail. A quick fix: https://github.com/apache/spark/pull/52422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
