Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6380#discussion_r31975251
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -527,6 +529,54 @@ class StreamingContext private[streaming] (
         scheduler.listenerBus.addListener(streamingListener)
       }
     
    +  /**
    +   * Registers streamingListeners specified in spark.streaming.listeners
    +   */
    +  private def setupStreamingListeners(): Unit = {
    +    // Use reflection to instantiate listeners specified via 
`spark.extraListeners`
    +    try {
    +      val listenerClassNames: Seq[String] =
    +        conf.get("spark.streaming.listeners", 
"").split(',').map(_.trim).filter(_ != "")
    +      for (className <- listenerClassNames) {
    +        // Use reflection to find the right constructor
    +        val constructors = {
    +          val listenerClass = Class.forName(className)
    +          listenerClass.getConstructors.asInstanceOf[Array[Constructor[_ 
<: StreamingListener]]]
    +        }
    +        val constructorTakingSparkConf = constructors.find { c =>
    --- End diff --
    
    I see. It will throw `NoSuchMethodException` and make the code complex.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to