Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/6394#discussion_r31975860
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1374,12 +1374,15 @@ class SparkContext(config: SparkConf) extends
Logging with ExecutorAllocationCli
* This can result in canceling pending requests or filing additional
requests.
* This is currently only supported in YARN mode. Return whether the
request is received.
*/
- private[spark] override def requestTotalExecutors(numExecutors: Int):
Boolean = {
+ private[spark] override def requestTotalExecutors(
+ numExecutors: Int,
+ localityAwarePendingTasks: Int,
+ preferredLocalityToCount: scala.Predef.Map[String, Int]): Boolean = {
--- End diff --
Hi @squito , thanks a lot for your explanation, since the previous code
already import `scala.collection.Map`, so here I have to write a full qualified
name here, I will change to immutable map :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
