Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/446#discussion_r12707097
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -248,17 +248,31 @@ private[hive] case class HiveGenericUdf(name: String,
children: Seq[Expression])
isUDFDeterministic && children.foldLeft(true)((prev, n) => prev &&
n.foldable)
}
+ protected lazy val deferedObjects =
Array.fill[DeferredObject](children.length)({
+ new DeferredObjectAdapter
+ })
+
+ // Adapter from Catalyst ExpressionResult to Hive DeferredObject
+ class DeferredObjectAdapter extends DeferredObject {
+ private var func: () => Any = _
+ def set(func: () => Any) {
+ this.func = func
+ }
+ override def prepare(i: Int) = {}
+ override def get(): AnyRef = wrap(func())
+ }
+
val dataType: DataType = inspectorToDataType(returnInspector)
override def eval(input: Row): Any = {
returnInspector // Make sure initialized.
- val args = children.map { v =>
- new DeferredObject {
- override def prepare(i: Int) = {}
- override def get(): AnyRef = wrap(v.eval(input))
- }
- }.toArray
- unwrap(function.evaluate(args))
+ var i = 0
+ while(i < children.length) {
--- End diff --
mind adding a space here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
