Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6423#discussion_r32081635
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala 
---
    @@ -17,23 +17,23 @@
     
     package org.apache.spark.storage
     
    +import java.io.InputStream
     import java.util.concurrent.LinkedBlockingQueue
     
     import scala.collection.mutable.{ArrayBuffer, HashSet, Queue}
     import scala.util.{Failure, Try}
     
    -import org.apache.spark.{Logging, TaskContext}
    -import org.apache.spark.network.shuffle.{BlockFetchingListener, 
ShuffleClient}
     import org.apache.spark.network.buffer.ManagedBuffer
    -import org.apache.spark.serializer.{SerializerInstance, Serializer}
    -import org.apache.spark.util.{CompletionIterator, Utils}
    +import org.apache.spark.network.shuffle.{BlockFetchingListener, 
ShuffleClient}
    +import org.apache.spark.util.Utils
    +import org.apache.spark.{Logging, TaskContext}
    --- End diff --
    
    @massie I also could never get this right on my own, but i discovered that 
aaron's plugin actually does the sorting the way we want, so I recommend using 
that over IntelliJ's built in import ordering tool.  I put the details on where 
to download it and configure it here:
    
    
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Imports


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to