Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6724#discussion_r32092473
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -294,3 +294,35 @@ object Substring {
apply(str, pos, Literal(Integer.MAX_VALUE))
}
}
+
+/**
+ * A function that return the length of the given string expression.
+ */
+case class StringLength(child: Expression) extends UnaryExpression with
ExpectsInputTypes {
+
+ override def foldable: Boolean = child.foldable
--- End diff --
maybe we can make them denser, i.e. remove the blank lines between the
trivial functions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
