yaooqinn commented on code in PR #55422:
URL: https://github.com/apache/spark/pull/55422#discussion_r3122383828
##########
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala:
##########
@@ -597,4 +597,16 @@ class SQLConfSuite extends QueryTest with
SharedSparkSession {
assert(e.getMessage.contains("forceSnapshotUploadOnLag"))
assert(e.getMessage.contains("coordinatorReportSnapshotUploadLag"))
}
+
+ test("SPARK-56546: segment-tree SQLConf entries declare SESSION
bindingPolicy") {
+ import org.apache.spark.internal.config.ConfigBindingPolicy
+ Seq(
+ SQLConf.WINDOW_SEGMENT_TREE_ENABLED,
+ SQLConf.WINDOW_SEGMENT_TREE_MIN_PARTITION_ROWS,
+ SQLConf.WINDOW_SEGMENT_TREE_BLOCK_SIZE,
+ SQLConf.WINDOW_SEGMENT_TREE_FANOUT).foreach { entry =>
+ assert(entry.bindingPolicy === Some(ConfigBindingPolicy.SESSION),
+ s"${entry.key} must declare SESSION bindingPolicy")
+ }
+ }
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
