cloud-fan commented on code in PR #51419:
URL: https://github.com/apache/spark/pull/51419#discussion_r3125380051


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCapability.java:
##########
@@ -100,5 +100,15 @@ public enum TableCapability {
    * write modes, like {@link #TRUNCATE}, and {@link #OVERWRITE_BY_FILTER}, 
but cannot support
    * {@link #OVERWRITE_DYNAMIC}.
    */
-  V1_BATCH_WRITE
+  V1_BATCH_WRITE,
+
+  /**
+   * Signals that the table is a general table which does not implement 
read/write directly,
+   * but relies on Spark to interpret the table metadata and read it as a view 
or resolve the

Review Comment:
   The capability has since been reshaped: `TableCapability` is gone in favor 
of the concrete `MetadataOnlyTable` for the read side, and a 
`TableCatalogCapability.SUPPORTS_VIEW` gate for the write side. The 
`SUPPORTS_VIEW` javadoc now spells out the affected operations explicitly 
(CREATE VIEW / CREATE OR REPLACE VIEW / CREATE VIEW IF NOT EXISTS via 
`createTable`, `ALTER VIEW ... AS` via `dropTable`+`createTable` or 
`stageReplace`, and the read-path round-trip through `MetadataOnlyTable`). PTAL 
and let me know if anything is still unclear.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to