dongjoon-hyun commented on code in PR #55476:
URL: https://github.com/apache/spark/pull/55476#discussion_r3126695640
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -5238,23 +5241,29 @@ case class ArrayInsert(
} else {
val pos = posExpr.value
val baseOffset = if (legacyNegativeIndex) 1 else 0
Review Comment:
This looks inconsistent to me because this PR changed like the following in
other code path.
```
val baseOffset: Long = if (legacyNegativeIndex) 1L else 0L
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
