cloud-fan commented on PR #55498: URL: https://github.com/apache/spark/pull/55498#issuecomment-4301864102
Summary of the force-pushes since the initial approval + review round (heads-up @LuciferYang that the HEAD has changed substantially): - **v2** (between your review and the benchmark-evidence comment): replaced the `HashMap.get(Object)` + autobox codegen body in `PrebuiltHashExecutor` with driver-built `int[] buckets` + SPARK-55959's inline primitive hash codegen. Local comparison (in the benchmark comment below) showed the v1 shape regressed foldable-map hash lookup 25-34% vs SPARK-55959; v2 matches SPARK-55959 within noise. - **v3** (this push, `94e80a9d553`): addresses your four review comments - predicate rationale block comment, `usesFoldableHashLookup` test helper, `strategy choice for foldable maps` test, plus the PR description wording fix. See individual replies on each comment thread. Flagging so you can decide whether the approval should carry over or if you want another round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
