zhengruifeng opened a new pull request, #55509: URL: https://github.com/apache/spark/pull/55509
### What changes were proposed in this pull request? Move seven members from `trait QueryTest` down to `trait QueryTestBase`. None of them depend on `AnyFunSuite.test(...)`, so they fit in `QueryTestBase` (self-type `Suite`) without changing the self-type: - `private var loadTestDataBeforeTests` - `override def beforeAll()` - `setupTestData()` - `waitForTasksToFinish()` - `withTempPaths(numPaths)(f)` - `getCurrentClassCallSitePattern` - `getNextLineCallSitePattern(lines)` All dependencies (`spark` from `SQLTestData`, `eventually`/`timeout` from `Eventually`, `super.beforeAll()` via `BeforeAndAfterAll`, `loadTestData` from `SQLTestData`) are already parents of `QueryTestBase`, so this is a pure relocation — the `super.beforeAll()` chain resolves the same way at the concrete-class level. ### Why are the changes needed? Making these helpers available to `QueryTestBase` allows tests that mix in `QueryTestBase` directly (without the `AnyFunSuite` overhead, e.g., non-FunSuite test styles) to reuse them. No functional change today; this lowers the bar for downstream test-style flexibility. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Locally compiled `sql/Test/compile`. Ran `SortSuite` (255 tests) — all pass. No call-site churn; every existing caller still reaches these through `QueryTest` via inheritance. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
