peter-toth commented on PR #55500: URL: https://github.com/apache/spark/pull/55500#issuecomment-4304350341
@cloud-fan , I opened a code cleanup and simplification PR yesterday: https://github.com/apache/spark/pull/55482. It also handles 1. of this PR, but probably the new test of this PR should be added to there. 2. analysis doesn't take into account that the supported set of nodes might change in the future, so when we handle `(np: Filter, cp)` and `(np, cp: Filter)` and `symmetricFilterPropagationEnabled` is enabled the we should prepare for non-empty `cpFilter` / `npFilter`. The current code is more robust IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
