TQJADE commented on PR #641: URL: https://github.com/apache/spark-kubernetes-operator/pull/641#issuecomment-4306100881
> I'm not sure if this PR is safe because `templates/crds` seems to be not protected during uninstallation. Could you double-check the CRD remains in the system during `helm uninstall` operation like before? > > > ### Does this PR introduce any user-facing change? > > No Thanks for catching this! The move from crds/ to templates/crds/ did lose Helm's built-in uninstall protection. I've addressed this by adding a configurable crds.annotations value, defaulting to "helm.sh/resource-policy": keep, which tells Helm to skip deleting CRDs on uninstall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
