LuciferYang commented on code in PR #55506:
URL: https://github.com/apache/spark/pull/55506#discussion_r3135761271
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala:
##########
@@ -1030,6 +1030,97 @@ class WholeStageCodegenSuite extends QueryTest with
SharedSparkSession
}
}
+ test("SPARK-56032: FilterExec CSE defers throw-capable notNullPred past
guard otherPred") {
Review Comment:
1. This test missing assert at L1111, but Test 1 does not. If a future
`supportCodegen` change or broadcast threshold flip drops
2. Maybe we should run the same query with
`WHOLESTAGE_CODEGEN_ENABLED=false` and check results match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
