huangxiaopingRD opened a new pull request, #55539: URL: https://github.com/apache/spark/pull/55539
### What changes were proposed in this pull request? This PR cleans up stale entries in RuleIdCollection by aligning rule names with the current Catalyst codebase. Specifically, it updates/removes outdated rule FQNs in: `sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala` **Changes made:** **Replaced outdated rule name:** ``` org.apache.spark.sql.catalyst.analysis.AnsiTypeCoercion$PromoteStringLiterals -> org.apache.spark.sql.catalyst.analysis.AnsiTypeCoercion$PromoteStrings ``` **Replaced outdated Analyzer-scoped transpose rule name:** ``` org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveTranspose -> org.apache.spark.sql.catalyst.analysis.ResolveTranspose ``` **Removed stale rule entries that no longer exist as concrete rules:** ``` Analyzer$ResolveAggAliasInGroupBy Analyzer$ResolveTables Analyzer$ResolveTempViews Analyzer$WrapLateralColumnAliasReference ResolveDefaultColumns ResolveGroupByAll ResolveHigherOrderFunctions ResolveOrderByAll SubstituteUnresolvedOrdinals ApplyCharTypePadding (also not appropriate for this list) ``` ### Why are the changes needed? RuleIdCollection is used to map repeatedly-invoked Catalyst rules to rule IDs for traversal pruning. Keeping stale/non-existent entries causes drift between metadata and actual rule definitions, and makes maintenance/review harder. This cleanup keeps RuleIdCollection consistent with current rule implementations and naming after multiple past refactors/renames. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Verified that updated FQNs correspond to existing current rule definitions. Verified that removed entries are stale and no longer map to active concrete rules. Performed manual consistency review of the edited RuleIdCollection contents. No new tests were added because this is an internal metadata cleanup without behavioral or API changes. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
