lunar-shadow opened a new pull request, #55547:
URL: https://github.com/apache/spark/pull/55547
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This fixes `ALTER TABLE ... RENAME TO` in a couple of cases that weren’t
handled correctly:
* When the target name is catalog-qualified in V2 catalogs
* When the target is just a table name (no namespace) in both V1 and V2
catalogs
**Changes:**
* Handle catalog-qualified targets correctly in V2 (strip catalog when it
matches source)
* Inherit source namespace when target is table-only (V1 & V2)
* Add tests covering the above cases
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Right now, rename behaves incorrectly in a few scenarios.
For example:
```sql
ALTER TABLE testcat.ns.t1 RENAME TO testcat.ns.t2;
```
fails because `asIdentifier` treats everything except the last part as the
namespace. That means the catalog name (`testcat`) incorrectly ends up inside
the namespace:
```scala
Identifier.of(["testcat", "ns"], "t2")
```
instead of:
```scala
Identifier.of(["ns"], "t2")
```
Similarly:
```sql
ALTER TABLE testcat.ns.t1 RENAME TO t2;
```
creates an identifier with an empty namespace, instead of inheriting `ns`
from the source table.
**Steps to reproduce:**
```sql
CREATE TABLE testcat.ns.t1 USING foo AS SELECT 1 AS id;
ALTER TABLE testcat.ns.t1 RENAME TO testcat.ns.t2;
```
This fails with a namespace resolution error due to the catalog being
treated as part of the namespace.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes.
* Catalog-qualified renames like ALTER TABLE catalog.ns.t1 RENAME TO
catalog.ns.t2 now work as expected
* Renaming to a table-only name (e.g., `RENAME TO t2`) now correctly keeps
the original namespace
* Cross-namespace renames (e.g., RENAME TO other_ns.t2) continue to work for
V2 catalogs as before
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added test coverage in `DataSourceV2SQLSuite`:
* Rename with catalog-qualified identifiers (including table-only and
namespace-qualified cases)
* Rename across namespaces for V2 catalogs
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
