szehon-ho commented on PR #55427: URL: https://github.com/apache/spark/pull/55427#issuecomment-4318390568
@cloud-fan thanks for the detailed review. I addressed the inline points in a single follow-up commit (pushed to this branch): - Propagate `fillDefaultValue` through `resolveArrayType` / `resolveMapType` by-position paths and added symmetric by-position tests for array-of-struct and map-of-struct. - Trailing default fill now uses `applyColumnMetadata` like the by-name path. - Clarified the `ResolveOutputRelation` comment and extended `spark.sql.insertNestedTypeCoercion.enabled` docs. - Fixed the negative by-name test to use `doInsertByName` + `INCOMPATIBLE_DATA_FOR_TABLE.CANNOT_FIND_DATA`, with `USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES=false` so FILL does not insert null under test defaults (otherwise no exception). - Updated `DefaultValueFillMode` scaladoc for RECURSE. Replies are threaded on each of your line comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
